Skip to content

gh-135497: fix MAXLOGNAME detection in configure#135508

Merged
picnixz merged 2 commits intopython:mainfrom
alebcay:fix-maxlogname-detection
Jun 14, 2025
Merged

gh-135497: fix MAXLOGNAME detection in configure#135508
picnixz merged 2 commits intopython:mainfrom
alebcay:fix-maxlogname-detection

Conversation

@alebcay
Copy link
Contributor

@alebcay alebcay commented Jun 14, 2025 •
edited by bedevere-app bot
Loading

@python-cla-bot
Copy link

python-cla-bot bot commented Jun 14, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jun 14, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jun 14, 2025
Closed
sobolevn
sobolevn reviewed Jun 14, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a NEWS entry :)

@alebcay alebcay force-pushed the fix-maxlogname-detection branch from 2326807 to 47b64df Compare June 14, 2025 14:23
picnixz
picnixz approved these changes Jun 14, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit and LGTM.

@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 14, 2025
@alebcay
Copy link
Contributor Author

alebcay commented Jun 14, 2025

Thanks for the pointer, still getting the hang of things around here :)

I've filed the news entry under Library, since the original issue/PR where the getlogin change was introduced is also filed under Library. If there is a more suitable place to put it, I'm happy to move it.

@alebcay alebcay force-pushed the fix-maxlogname-detection branch from 47b64df to d835360 Compare June 14, 2025 14:25
@picnixz
Copy link
Member

picnixz commented Jun 14, 2025 •
edited
Loading

I've filed the news entry under Library, since the original issue/PR where the getlogin change was introduced is also filed under Library. If there is a more suitable place to put it, I'm happy to move it.

You could add another NEWS entry under 'Build' indicating that we now correctly detect MAXLOGNAME constant (without mentioning getlogin_r). But otherwise, I think it's fine as it is.

@alebcay alebcay force-pushed the fix-maxlogname-detection branch from d835360 to 33048e9 Compare June 14, 2025 14:32
@picnixz picnixz enabled auto-merge (squash) June 14, 2025 15:47
@picnixz picnixz merged commit 2e15a50 into python:main Jun 14, 2025
35 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Jun 14, 2025

Thanks @alebcay for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2025
@alebcay @miss-islington
pythongh-135497: fix MAXLOGNAME detection in configure.ac (python…
3ed3256 
…GH-135508)

(cherry picked from commit 2e15a50)

Co-authored-by: Caleb Xu <calebcenter@live.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 14, 2025

GH-135516 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 14, 2025
@alebcay @miss-islington
pythongh-135497: fix MAXLOGNAME detection in configure.ac (python…
4cd03f3 
…GH-135508)

(cherry picked from commit 2e15a50)

Co-authored-by: Caleb Xu <calebcenter@live.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 14, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 14, 2025

GH-135517 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 14, 2025
picnixz pushed a commit that referenced this pull request Jun 14, 2025
@miss-islington @alebcay
[3.13] gh-135497: fix MAXLOGNAME detection in configure.ac (GH-13…
1534077 
…5508) (#135517)

gh-135497: fix `MAXLOGNAME` detection in `configure.ac` (GH-135508)
(cherry picked from commit 2e15a50)

Co-authored-by: Caleb Xu <calebcenter@live.com>
picnixz pushed a commit that referenced this pull request Jun 14, 2025
@miss-islington @alebcay
[3.14] gh-135497: fix MAXLOGNAME detection in configure.ac (GH-13…
c5f066d 
…5508) (#135516)

gh-135497: fix `MAXLOGNAME` detection in `configure.ac` (GH-135508)
(cherry picked from commit 2e15a50)

Co-authored-by: Caleb Xu <calebcenter@live.com>
shuimu5418 pushed a commit to shuimu5418/cpython001 that referenced this pull request Jun 16, 2025
@alebcay @shuimu5418
pythongh-135497: fix MAXLOGNAME detection in configure.ac (python…
df6e5b3 
…#135508)
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@alebcay @lkollar
pythongh-135497: fix MAXLOGNAME detection in configure.ac (python…
736b729 
…#135508)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@alebcay @Pranjal095
pythongh-135497: fix MAXLOGNAME detection in configure.ac (python…
8902fe6 
…#135508)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@alebcay @taegyunkim
pythongh-135497: fix MAXLOGNAME detection in configure.ac (python…
a6f741d 
…#135508)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@alebcay @Agent-Hellboy
pythongh-135497: fix MAXLOGNAME detection in configure.ac (python…
58edd1b 
…#135508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments

@picnixz picnixz picnixz approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alebcay @picnixz @sobolevn